Преглед изворни кода

PM / OPP replace kfree_rcu() with call_srcu() in opp_set_availability()

This existed before we introduced call_srcu() in opp layer to synchronize with
srcu_notifier_call_chain() while removing OPPs. And is a potential bug which
wasn't noticed earlier.

Let fix it as well by using the right API to free OPP.

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Viresh Kumar пре 11 година
родитељ
комит
b4037aaa58
1 измењених фајлова са 1 додато и 1 уклоњено
  1. 1 1
      drivers/base/power/opp.c

+ 1 - 1
drivers/base/power/opp.c

@@ -641,7 +641,7 @@ static int opp_set_availability(struct device *dev, unsigned long freq,
 
 
 	list_replace_rcu(&opp->node, &new_opp->node);
 	list_replace_rcu(&opp->node, &new_opp->node);
 	mutex_unlock(&dev_opp_list_lock);
 	mutex_unlock(&dev_opp_list_lock);
-	kfree_rcu(opp, rcu_head);
+	call_srcu(&dev_opp->srcu_head.srcu, &opp->rcu_head, kfree_opp_rcu);
 
 
 	/* Notify the change of the OPP availability */
 	/* Notify the change of the OPP availability */
 	if (availability_req)
 	if (availability_req)