瀏覽代碼

staging: comedi: usbdux: remove an unnecessary dev_info()

usbdux_attach_common() prints two messages via dev_info() that shows a
device has been attached.  The first of these messages includes an index
into a static array that the function determines by pointer subtraction,
assuming the pointer passed to the function points to an element of the
array.  Dan Carpenter pointed out that this was kind of ugly.  Since the
dev_info() that prints the array index doesn't add anything useful
(since no other messages print the array index and nothing else uses
it), let's just get rid of it.

Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ian Abbott 13 年之前
父節點
當前提交
b3f79f980a
共有 1 個文件被更改,包括 0 次插入4 次删除
  1. 0 4
      drivers/staging/comedi/drivers/usbdux.c

+ 0 - 4
drivers/staging/comedi/drivers/usbdux.c

@@ -2623,7 +2623,6 @@ static int usbdux_attach_common(struct comedi_device *dev,
 				void *aux_data, int aux_len)
 {
 	int ret;
-	int index = (int)(udev - usbduxsub);
 	struct comedi_subdevice *s = NULL;
 
 	down(&udev->sem);
@@ -2654,9 +2653,6 @@ static int usbdux_attach_common(struct comedi_device *dev,
 		return ret;
 	}
 
-	dev_info(&udev->interface->dev,
-		 "comedi%d: usb-device %d is attached to comedi.\n",
-		 dev->minor, index);
 	/* private structure is also simply the usb-structure */
 	dev->private = udev;