Browse Source

ata: pata_pdc2027x: Replace mdelay with msleep

After checking all possible call chains to pdc_adjust_pll and
pdc_detect_pll_input_clock,
my tool finds that these functions are never called in atomic context,
namely never in an interrupt handler or holding a spinlock.
And their caller functions pdc2027x_init_one and pdc2027x_reinit_one
calls pci_enable_device which can sleep, and no spinlock is held when
calling pdc_adjust_pll and pdc_detect_pll_input_clock,
so it proves that pdc_adjust_pll and pdc_detect_pll_input_clock
can call functions which can sleep.
Thus mdelay can be replaced with msleep to avoid busy wait.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
Jia-Ju Bai 7 years ago
parent
commit
b3506c7ed2
1 changed files with 2 additions and 2 deletions
  1. 2 2
      drivers/ata/pata_pdc2027x.c

+ 2 - 2
drivers/ata/pata_pdc2027x.c

@@ -580,7 +580,7 @@ static void pdc_adjust_pll(struct ata_host *host, long pll_clock, unsigned int b
 	ioread16(mmio_base + PDC_PLL_CTL); /* flush */
 	ioread16(mmio_base + PDC_PLL_CTL); /* flush */
 
 
 	/* Wait the PLL circuit to be stable */
 	/* Wait the PLL circuit to be stable */
-	mdelay(30);
+	msleep(30);
 
 
 #ifdef PDC_DEBUG
 #ifdef PDC_DEBUG
 	/*
 	/*
@@ -620,7 +620,7 @@ static long pdc_detect_pll_input_clock(struct ata_host *host)
 	start_time = ktime_get();
 	start_time = ktime_get();
 
 
 	/* Let the counter run for 100 ms. */
 	/* Let the counter run for 100 ms. */
-	mdelay(100);
+	msleep(100);
 
 
 	/* Read the counter values again */
 	/* Read the counter values again */
 	end_count = pdc_read_counter(host);
 	end_count = pdc_read_counter(host);