瀏覽代碼

clk: asm9260: Fix of_io_request_and_map error check

of_io_request_and map returns an error pointer, but the current code assumes
that on error the returned pointer will be NULL.

Obviously, that makes the check completely useless. Change the test to actually
check for the proper error code.

Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: Mike Turquette <mturquette@linaro.org>
Cc: Stephen Boyd <sboyd@codeaurora.org>
Cc: linux-clk@vger.kernel.org
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
Maxime Ripard 10 年之前
父節點
當前提交
b1ed311baf
共有 1 個文件被更改,包括 1 次插入1 次删除
  1. 1 1
      drivers/clk/clk-asm9260.c

+ 1 - 1
drivers/clk/clk-asm9260.c

@@ -274,7 +274,7 @@ static void __init asm9260_acc_init(struct device_node *np)
 	u32 accuracy = 0;
 	u32 accuracy = 0;
 
 
 	base = of_io_request_and_map(np, 0, np->name);
 	base = of_io_request_and_map(np, 0, np->name);
-	if (!base)
+	if (IS_ERR(base))
 		panic("%s: unable to map resource", np->name);
 		panic("%s: unable to map resource", np->name);
 
 
 	/* register pll */
 	/* register pll */