浏览代码

function_graph: Have profiler use curr_ret_stack and not depth

The profiler uses trace->depth to find its entry on the ret_stack, but the
depth may not match the actual location of where its entry is (if an
interrupt were to preempt the processing of the profiler for another
function, the depth and the curr_ret_stack will be different).

Have it use the curr_ret_stack as the index to find its ret_stack entry
instead of using the depth variable, as that is no longer guaranteed to be
the same.

Cc: stable@kernel.org
Fixes: 03274a3ffb449 ("tracing/fgraph: Adjust fgraph depth before calling trace return callback")
Reviewed-by: Masami Hiramatsu <mhiramat@kernel.org>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Steven Rostedt (VMware) 6 年之前
父节点
当前提交
b1b35f2e21
共有 1 个文件被更改,包括 2 次插入2 次删除
  1. 2 2
      kernel/trace/ftrace.c

+ 2 - 2
kernel/trace/ftrace.c

@@ -817,7 +817,7 @@ function_profile_call(unsigned long ip, unsigned long parent_ip,
 #ifdef CONFIG_FUNCTION_GRAPH_TRACER
 #ifdef CONFIG_FUNCTION_GRAPH_TRACER
 static int profile_graph_entry(struct ftrace_graph_ent *trace)
 static int profile_graph_entry(struct ftrace_graph_ent *trace)
 {
 {
-	int index = trace->depth;
+	int index = current->curr_ret_stack;
 
 
 	function_profile_call(trace->func, 0, NULL, NULL);
 	function_profile_call(trace->func, 0, NULL, NULL);
 
 
@@ -852,7 +852,7 @@ static void profile_graph_return(struct ftrace_graph_ret *trace)
 	if (!fgraph_graph_time) {
 	if (!fgraph_graph_time) {
 		int index;
 		int index;
 
 
-		index = trace->depth;
+		index = current->curr_ret_stack;
 
 
 		/* Append this call time to the parent time to subtract */
 		/* Append this call time to the parent time to subtract */
 		if (index)
 		if (index)