浏览代码

drm/i915: Update the restrict check to filter out wrong Ring ID passed by user-space

Signed-off-by: Zhao Yakui <yakui.zhao@intel.com>
Reviewed-by: Imre Deak <imre.deak@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Zhao Yakui 11 年之前
父节点
当前提交
b1a93306ed
共有 2 个文件被更改,包括 2 次插入1 次删除
  1. 1 1
      drivers/gpu/drm/i915/i915_gem_execbuffer.c
  2. 1 0
      drivers/gpu/drm/i915/intel_ringbuffer.h

+ 1 - 1
drivers/gpu/drm/i915/i915_gem_execbuffer.c

@@ -1037,7 +1037,7 @@ i915_gem_do_execbuffer(struct drm_device *dev, void *data,
 	if (args->flags & I915_EXEC_IS_PINNED)
 	if (args->flags & I915_EXEC_IS_PINNED)
 		flags |= I915_DISPATCH_PINNED;
 		flags |= I915_DISPATCH_PINNED;
 
 
-	if ((args->flags & I915_EXEC_RING_MASK) > I915_NUM_RINGS) {
+	if ((args->flags & I915_EXEC_RING_MASK) > LAST_USER_RING) {
 		DRM_DEBUG("execbuf with unknown ring: %d\n",
 		DRM_DEBUG("execbuf with unknown ring: %d\n",
 			  (int)(args->flags & I915_EXEC_RING_MASK));
 			  (int)(args->flags & I915_EXEC_RING_MASK));
 		return -EINVAL;
 		return -EINVAL;

+ 1 - 0
drivers/gpu/drm/i915/intel_ringbuffer.h

@@ -63,6 +63,7 @@ struct  intel_ring_buffer {
 		VECS,
 		VECS,
 	} id;
 	} id;
 #define I915_NUM_RINGS 4
 #define I915_NUM_RINGS 4
+#define LAST_USER_RING (VECS + 1)
 	u32		mmio_base;
 	u32		mmio_base;
 	void		__iomem *virtual_start;
 	void		__iomem *virtual_start;
 	struct		drm_device *dev;
 	struct		drm_device *dev;