Explorar o código

mtd: physmap_of: fix set but unused warning

drivers/mtd/maps/physmap_of.c: In function ‘of_flash_probe’:
drivers/mtd/maps/physmap_of.c:165:16: warning: variable ‘p’ set but not used [-Wunused-but-set-variable]

This could be a problem if the 'reg' property is not set, since that
means 'count' will be uninitialized.

Signed-off-by: Brian Norris <computersforpeace@gmail.com>
Brian Norris %!s(int64=9) %!d(string=hai) anos
pai
achega
b137aab438
Modificáronse 1 ficheiros con 1 adicións e 1 borrados
  1. 1 1
      drivers/mtd/maps/physmap_of.c

+ 1 - 1
drivers/mtd/maps/physmap_of.c

@@ -186,7 +186,7 @@ static int of_flash_probe(struct platform_device *dev)
 	 * consists internally of 2 non-identical NOR chips on one die.
 	 */
 	p = of_get_property(dp, "reg", &count);
-	if (count % reg_tuple_size != 0) {
+	if (!p || count % reg_tuple_size != 0) {
 		dev_err(&dev->dev, "Malformed reg property on %s\n",
 				dev->dev.of_node->full_name);
 		err = -EINVAL;