瀏覽代碼

timekeeping: Pass readout base to update_fast_timekeeper()

Modify update_fast_timekeeper() to take a struct tk_read_base
pointer as its argument (instead of a struct timekeeper pointer)
and update its kerneldoc comment to reflect that.

That will allow a struct tk_read_base that is not part of a
struct timekeeper to be passed to it in the next patch.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Acked-by: John Stultz <john.stultz@linaro.org>
Rafael J. Wysocki 10 年之前
父節點
當前提交
affe3e85ae
共有 1 個文件被更改,包括 6 次插入8 次删除
  1. 6 8
      kernel/time/timekeeping.c

+ 6 - 8
kernel/time/timekeeping.c

@@ -230,9 +230,7 @@ static inline s64 timekeeping_get_ns_raw(struct timekeeper *tk)
 
 
 /**
 /**
  * update_fast_timekeeper - Update the fast and NMI safe monotonic timekeeper.
  * update_fast_timekeeper - Update the fast and NMI safe monotonic timekeeper.
- * @tk:		The timekeeper from which we take the update
- * @tkf:	The fast timekeeper to update
- * @tbase:	The time base for the fast timekeeper (mono/raw)
+ * @tkr: Timekeeping readout base from which we take the update
  *
  *
  * We want to use this from any context including NMI and tracing /
  * We want to use this from any context including NMI and tracing /
  * instrumenting the timekeeping code itself.
  * instrumenting the timekeeping code itself.
@@ -244,11 +242,11 @@ static inline s64 timekeeping_get_ns_raw(struct timekeeper *tk)
  * smp_wmb();	<- Ensure that the last base[1] update is visible
  * smp_wmb();	<- Ensure that the last base[1] update is visible
  * tkf->seq++;
  * tkf->seq++;
  * smp_wmb();	<- Ensure that the seqcount update is visible
  * smp_wmb();	<- Ensure that the seqcount update is visible
- * update(tkf->base[0], tk);
+ * update(tkf->base[0], tkr);
  * smp_wmb();	<- Ensure that the base[0] update is visible
  * smp_wmb();	<- Ensure that the base[0] update is visible
  * tkf->seq++;
  * tkf->seq++;
  * smp_wmb();	<- Ensure that the seqcount update is visible
  * smp_wmb();	<- Ensure that the seqcount update is visible
- * update(tkf->base[1], tk);
+ * update(tkf->base[1], tkr);
  *
  *
  * The reader side does:
  * The reader side does:
  *
  *
@@ -269,7 +267,7 @@ static inline s64 timekeeping_get_ns_raw(struct timekeeper *tk)
  * slightly wrong timestamp (a few nanoseconds). See
  * slightly wrong timestamp (a few nanoseconds). See
  * @ktime_get_mono_fast_ns.
  * @ktime_get_mono_fast_ns.
  */
  */
-static void update_fast_timekeeper(struct timekeeper *tk)
+static void update_fast_timekeeper(struct tk_read_base *tkr)
 {
 {
 	struct tk_read_base *base = tk_fast_mono.base;
 	struct tk_read_base *base = tk_fast_mono.base;
 
 
@@ -277,7 +275,7 @@ static void update_fast_timekeeper(struct timekeeper *tk)
 	raw_write_seqcount_latch(&tk_fast_mono.seq);
 	raw_write_seqcount_latch(&tk_fast_mono.seq);
 
 
 	/* Update base[0] */
 	/* Update base[0] */
-	memcpy(base, &tk->tkr, sizeof(*base));
+	memcpy(base, tkr, sizeof(*base));
 
 
 	/* Force readers back to base[0] */
 	/* Force readers back to base[0] */
 	raw_write_seqcount_latch(&tk_fast_mono.seq);
 	raw_write_seqcount_latch(&tk_fast_mono.seq);
@@ -462,7 +460,7 @@ static void timekeeping_update(struct timekeeper *tk, unsigned int action)
 		memcpy(&shadow_timekeeper, &tk_core.timekeeper,
 		memcpy(&shadow_timekeeper, &tk_core.timekeeper,
 		       sizeof(tk_core.timekeeper));
 		       sizeof(tk_core.timekeeper));
 
 
-	update_fast_timekeeper(tk);
+	update_fast_timekeeper(&tk->tkr);
 }
 }
 
 
 /**
 /**