Browse Source

rcu: Consolidate expedited GP code into exp_funnel_lock()

This commit pulls the grace-period-start counter adjustment and tracing
from synchronize_rcu_expedited() and synchronize_sched_expedited()
into exp_funnel_lock(), thus eliminating some code duplication.

Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Paul E. McKenney 9 years ago
parent
commit
aff12cdf86
2 changed files with 2 additions and 6 deletions
  1. 2 3
      kernel/rcu/tree.c
  2. 0 3
      kernel/rcu/tree_plugin.h

+ 2 - 3
kernel/rcu/tree.c

@@ -3653,6 +3653,8 @@ fastpath:
 		mutex_unlock(&rsp->exp_mutex);
 		mutex_unlock(&rsp->exp_mutex);
 		return true;
 		return true;
 	}
 	}
+	rcu_exp_gp_seq_start(rsp);
+	trace_rcu_exp_grace_period(rsp->name, s, TPS("start"));
 	return false;
 	return false;
 }
 }
 
 
@@ -3905,9 +3907,6 @@ void synchronize_sched_expedited(void)
 	if (exp_funnel_lock(rsp, s))
 	if (exp_funnel_lock(rsp, s))
 		return;  /* Someone else did our work for us. */
 		return;  /* Someone else did our work for us. */
 
 
-	rcu_exp_gp_seq_start(rsp);
-	trace_rcu_exp_grace_period(rsp->name, s, TPS("start"));
-
 	/* Initialize the rcu_node tree in preparation for the wait. */
 	/* Initialize the rcu_node tree in preparation for the wait. */
 	sync_rcu_exp_select_cpus(rsp, sync_sched_exp_handler);
 	sync_rcu_exp_select_cpus(rsp, sync_sched_exp_handler);
 
 

+ 0 - 3
kernel/rcu/tree_plugin.h

@@ -751,9 +751,6 @@ void synchronize_rcu_expedited(void)
 	if (exp_funnel_lock(rsp, s))
 	if (exp_funnel_lock(rsp, s))
 		return;  /* Someone else did our work for us. */
 		return;  /* Someone else did our work for us. */
 
 
-	rcu_exp_gp_seq_start(rsp);
-	trace_rcu_exp_grace_period(rsp->name, s, TPS("start"));
-
 	/* Initialize the rcu_node tree in preparation for the wait. */
 	/* Initialize the rcu_node tree in preparation for the wait. */
 	sync_rcu_exp_select_cpus(rsp, sync_rcu_exp_handler);
 	sync_rcu_exp_select_cpus(rsp, sync_rcu_exp_handler);