Przeglądaj źródła

ip6_gre: fix potential memory leak in ip6erspan_rcv

If md is NULL, tun_dst must be freed, otherwise it will cause memory
leak.

Fixes: ef7baf5e083c ("ip6_gre: add ip6 erspan collect_md mode")
Cc: William Tu <u9012063@gmail.com>
Signed-off-by: Haishuang Yan <yanhaishuang@cmss.chinamobile.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Haishuang Yan 7 lat temu
rodzic
commit
afb4c97d90
1 zmienionych plików z 3 dodań i 1 usunięć
  1. 3 1
      net/ipv6/ip6_gre.c

+ 3 - 1
net/ipv6/ip6_gre.c

@@ -550,8 +550,10 @@ static int ip6erspan_rcv(struct sk_buff *skb, int gre_hdr_len,
 
 
 			info = &tun_dst->u.tun_info;
 			info = &tun_dst->u.tun_info;
 			md = ip_tunnel_info_opts(info);
 			md = ip_tunnel_info_opts(info);
-			if (!md)
+			if (!md) {
+				dst_release((struct dst_entry *)tun_dst);
 				return PACKET_REJECT;
 				return PACKET_REJECT;
+			}
 
 
 			memcpy(md, pkt_md, sizeof(*md));
 			memcpy(md, pkt_md, sizeof(*md));
 			md->version = ver;
 			md->version = ver;