Home Explore Help
Sign In
GfA
/
linux_kernel
5
0
Fork 0
Files Issues 0 Pull Requests 0 Wiki
Browse Source

batman-adv: fix lockdep splat when doing mcast_free

While testing, we got something like this:

WARNING: CPU: 0 PID: 238 at net/batman-adv/multicast.c:142 batadv_mcast_mla_tt_retract+0x94/0x205 [batman_adv]()
[...]
Call Trace:
[<ffffffff815fc597>] dump_stack+0x4b/0x64
[<ffffffff810b34dc>] warn_slowpath_common+0xbc/0x120
[<ffffffffa0024ec5>] ? batadv_mcast_mla_tt_retract+0x94/0x205 [batman_adv]
[<ffffffff810b3705>] warn_slowpath_null+0x15/0x20
[<ffffffffa0024ec5>] batadv_mcast_mla_tt_retract+0x94/0x205 [batman_adv]
[<ffffffffa00273fe>] batadv_mcast_free+0x36/0x39 [batman_adv]
[<ffffffffa0020c77>] batadv_mesh_free+0x7d/0x13f [batman_adv]
[<ffffffffa0036a6b>] batadv_softif_free+0x15/0x25 [batman_adv]
[...]

Signed-off-by: Simon Wunderlich <simon@open-mesh.com>
Signed-off-by: Marek Lindner <mareklindner@neomailbox.ch>
Signed-off-by: Antonio Quartulli <a@unstable.cc>
Simon Wunderlich 9 years ago
parent
f1640c3dde
commit
af63cf51b7
1 changed files with 2 additions and 0 deletions
Split View Show Diff Stats
  1. 2 0
      net/batman-adv/multicast.c

+ 2 - 0
net/batman-adv/multicast.c
View File 

@@ -802,7 +802,9 @@ void batadv_mcast_free(struct batadv_priv *bat_priv)
 
 	batadv_tvlv_container_unregister(bat_priv, BATADV_TVLV_MCAST, 1);
 
 	batadv_tvlv_handler_unregister(bat_priv, BATADV_TVLV_MCAST, 1);
 
 
+	spin_lock_bh(&bat_priv->tt.commit_lock);
 
 	batadv_mcast_mla_tt_retract(bat_priv, NULL);
 
+	spin_unlock_bh(&bat_priv->tt.commit_lock);
 
 }
 
 
 /**