Browse Source

iio: lsiio: fix error code handling error

commit acf50b3586f8d8a7530b905e111dda41876d38f4
"tools:iio:lsiio: add error handling"
introduced error handling of errors returned from
read_sysfs_string(), but with a simple if (retval),
missing the fact that these functions return a positive
value if the read was successful.

As a result lsiio regresses and does not show any
devices on my filesystem. Fix this by checking for
only negative error codes.

Cc: Hartmut Knaack <knaack.h@gmx.de>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Acked-by: Hartmut Knaack <knaack.h@gmx.de>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
Linus Walleij 10 năm trước cách đây
mục cha
commit
af255cd562
1 tập tin đã thay đổi với 2 bổ sung2 xóa
  1. 2 2
      tools/iio/lsiio.c

+ 2 - 2
tools/iio/lsiio.c

@@ -69,7 +69,7 @@ static int dump_one_device(const char *dev_dir_name)
 		return -EINVAL;
 
 	ret = read_sysfs_string("name", dev_dir_name, name);
-	if (ret)
+	if (ret < 0)
 		return ret;
 
 	printf("Device %03d: %s\n", dev_idx, name);
@@ -92,7 +92,7 @@ static int dump_one_trigger(const char *dev_dir_name)
 		return -EINVAL;
 
 	ret = read_sysfs_string("name", dev_dir_name, name);
-	if (ret)
+	if (ret < 0)
 		return ret;
 
 	printf("Trigger %03d: %s\n", dev_idx, name);