Browse Source

sparc: use memdup_user_nul in sun4m LED driver

Use memdup_user_nul() helper instead of open-coding to simplify the code.

Signed-off-by: Geliang Tang <geliangtang@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Geliang Tang 8 years ago
parent
commit
aed74ea0a0
1 changed files with 3 additions and 10 deletions
  1. 3 10
      arch/sparc/kernel/led.c

+ 3 - 10
arch/sparc/kernel/led.c

@@ -70,16 +70,9 @@ static ssize_t led_proc_write(struct file *file, const char __user *buffer,
 	if (count > LED_MAX_LENGTH)
 	if (count > LED_MAX_LENGTH)
 		count = LED_MAX_LENGTH;
 		count = LED_MAX_LENGTH;
 
 
-	buf = kmalloc(sizeof(char) * (count + 1), GFP_KERNEL);
-	if (!buf)
-		return -ENOMEM;
-
-	if (copy_from_user(buf, buffer, count)) {
-		kfree(buf);
-		return -EFAULT;
-	}
-
-	buf[count] = '\0';
+	buf = memdup_user_nul(buffer, count);
+	if (IS_ERR(buf))
+		return PTR_ERR(buf);
 
 
 	/* work around \n when echo'ing into proc */
 	/* work around \n when echo'ing into proc */
 	if (buf[count - 1] == '\n')
 	if (buf[count - 1] == '\n')