Browse Source

sit: remove unnecessary protocol check in ipip6_tunnel_xmit()

ipip6_tunnel_xmit() is called immediately after checking that
skb->protocol is  htons(ETH_P_IPV6) so there is no need
to check it a second time.

Found by inspection.

Signed-off-by: Simon Horman <simon.horman@netronome.com>
Reviewed-by: Dinan Gunawardena <dinan.gunawardena@netronome.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Simon Horman 9 years ago
parent
commit
adba931fbc
1 changed files with 0 additions and 3 deletions
  1. 0 3
      net/ipv6/sit.c

+ 0 - 3
net/ipv6/sit.c

@@ -825,9 +825,6 @@ static netdev_tx_t ipip6_tunnel_xmit(struct sk_buff *skb,
 	u8 protocol = IPPROTO_IPV6;
 	u8 protocol = IPPROTO_IPV6;
 	int t_hlen = tunnel->hlen + sizeof(struct iphdr);
 	int t_hlen = tunnel->hlen + sizeof(struct iphdr);
 
 
-	if (skb->protocol != htons(ETH_P_IPV6))
-		goto tx_error;
-
 	if (tos == 1)
 	if (tos == 1)
 		tos = ipv6_get_dsfield(iph6);
 		tos = ipv6_get_dsfield(iph6);