浏览代码

drm/i915: store ring hangcheck action

For guilty batchbuffer analysis later on when rings are reset,
store what state the ring was on when hang was declared.
This helps to weed out the waiting rings from the active ones.

Signed-off-by: Mika Kuoppala <mika.kuoppala@intel.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Acked-by: Ben Widawsky <ben@bwidawsk.net>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Mika Kuoppala 12 年之前
父节点
当前提交
ad8beaeada
共有 2 个文件被更改,包括 9 次插入2 次删除
  1. 6 2
      drivers/gpu/drm/i915/i915_irq.c
  2. 3 0
      drivers/gpu/drm/i915/intel_ringbuffer.h

+ 6 - 2
drivers/gpu/drm/i915/i915_irq.c

@@ -2380,7 +2380,8 @@ static void semaphore_clear_deadlocks(struct drm_i915_private *dev_priv)
 		ring->hangcheck.deadlock = false;
 		ring->hangcheck.deadlock = false;
 }
 }
 
 
-static enum { wait, active, kick, hung } ring_stuck(struct intel_ring_buffer *ring, u32 acthd)
+static enum intel_ring_hangcheck_action
+ring_stuck(struct intel_ring_buffer *ring, u32 acthd)
 {
 {
 	struct drm_device *dev = ring->dev;
 	struct drm_device *dev = ring->dev;
 	struct drm_i915_private *dev_priv = dev->dev_private;
 	struct drm_i915_private *dev_priv = dev->dev_private;
@@ -2483,7 +2484,10 @@ void i915_hangcheck_elapsed(unsigned long data)
 				 * being repeatedly kicked and so responsible
 				 * being repeatedly kicked and so responsible
 				 * for stalling the machine.
 				 * for stalling the machine.
 				 */
 				 */
-				switch (ring_stuck(ring, acthd)) {
+				ring->hangcheck.action = ring_stuck(ring,
+								    acthd);
+
+				switch (ring->hangcheck.action) {
 				case wait:
 				case wait:
 					score = 0;
 					score = 0;
 					break;
 					break;

+ 3 - 0
drivers/gpu/drm/i915/intel_ringbuffer.h

@@ -37,11 +37,14 @@ struct  intel_hw_status_page {
 #define I915_READ_SYNC_0(ring) I915_READ(RING_SYNC_0((ring)->mmio_base))
 #define I915_READ_SYNC_0(ring) I915_READ(RING_SYNC_0((ring)->mmio_base))
 #define I915_READ_SYNC_1(ring) I915_READ(RING_SYNC_1((ring)->mmio_base))
 #define I915_READ_SYNC_1(ring) I915_READ(RING_SYNC_1((ring)->mmio_base))
 
 
+enum intel_ring_hangcheck_action { wait, active, kick, hung };
+
 struct intel_ring_hangcheck {
 struct intel_ring_hangcheck {
 	bool deadlock;
 	bool deadlock;
 	u32 seqno;
 	u32 seqno;
 	u32 acthd;
 	u32 acthd;
 	int score;
 	int score;
+	enum intel_ring_hangcheck_action action;
 };
 };
 
 
 struct  intel_ring_buffer {
 struct  intel_ring_buffer {