Browse Source

nvmem: core: Fix memory leak in nvmem_cell_write

A tmp buffer is allocated if cell->bit_offset || cell->nbits.
So the tmp buffer needs to be freed at the same condition to avoid leak.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Axel Lin 10 years ago
parent
commit
ace2217065
1 changed files with 1 additions and 1 deletions
  1. 1 1
      drivers/nvmem/core.c

+ 1 - 1
drivers/nvmem/core.c

@@ -938,7 +938,7 @@ int nvmem_cell_write(struct nvmem_cell *cell, void *buf, size_t len)
 	rc = regmap_raw_write(nvmem->regmap, cell->offset, buf, cell->bytes);
 	rc = regmap_raw_write(nvmem->regmap, cell->offset, buf, cell->bytes);
 
 
 	/* free the tmp buffer */
 	/* free the tmp buffer */
-	if (cell->bit_offset)
+	if (cell->bit_offset || cell->nbits)
 		kfree(buf);
 		kfree(buf);
 
 
 	if (IS_ERR_VALUE(rc))
 	if (IS_ERR_VALUE(rc))