Jelajahi Sumber

scsi: set correct completion code in scsi_send_eh_cmnd()

->queuecommand returns '0' for successful command submission,
so we need to set the correct SCSI midlayer return value
when calling scsi_log_completion().

Signed-off-by: Hannes Reinecke <hare@suse.de>
Reported-by: Robert Elliott <elliott@hp.com>
Cc: Stephen Cameron <scameron@beardog.cce.hp.com>
Tested-by: Robert Elliott <elliott@hp.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Hannes Reinecke 11 tahun lalu
induk
melakukan
ac61d19559
1 mengubah file dengan 1 tambahan dan 0 penghapusan
  1. 1 0
      drivers/scsi/scsi_error.c

+ 1 - 0
drivers/scsi/scsi_error.c

@@ -1029,6 +1029,7 @@ static int scsi_send_eh_cmnd(struct scsi_cmnd *scmd, unsigned char *cmnd,
 		rtn = NEEDS_RETRY;
 	} else {
 		timeleft = wait_for_completion_timeout(&done, timeout);
+		rtn = SUCCESS;
 	}
 
 	shost->eh_action = NULL;