Home Explore Help
Sign In
GfA
/
linux_kernel
5
0
Fork 0
Files Issues 0 Pull Requests 0 Wiki
Browse Source

net: sched: use __skb_queue_head_init() where applicable

pfifo_fast and htb use skb lists, without needing their spinlocks.
(They instead use the standard qdisc lock)

We can use __skb_queue_head_init() instead of skb_queue_head_init()
to be consistent.

Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Eric Dumazet 11 years ago
parent
0ce77802f3
commit
ab34f64808
2 changed files with 2 additions and 2 deletions
Split View Show Diff Stats
  1. 1 1
      net/sched/sch_generic.c
  2. 1 1
      net/sched/sch_htb.c

+ 1 - 1
net/sched/sch_generic.c
View File 

@@ -523,7 +523,7 @@ static int pfifo_fast_init(struct Qdisc *qdisc, struct nlattr *opt)
 
 	struct pfifo_fast_priv *priv = qdisc_priv(qdisc);
 
 
 	for (prio = 0; prio < PFIFO_FAST_BANDS; prio++)
 
-		skb_queue_head_init(band2list(priv, prio));
 
+		__skb_queue_head_init(band2list(priv, prio));
 
 
 	/* Can by-pass the queue discipline */
 
 	qdisc->flags |= TCQ_F_CAN_BYPASS;

+ 1 - 1
net/sched/sch_htb.c
View File 

@@ -1044,7 +1044,7 @@ static int htb_init(struct Qdisc *sch, struct nlattr *opt)
 
 
 	qdisc_watchdog_init(&q->watchdog, sch);
 
 	INIT_WORK(&q->work, htb_work_func);
 
-	skb_queue_head_init(&q->direct_queue);
 
+	__skb_queue_head_init(&q->direct_queue);
 
 
 	if (tb[TCA_HTB_DIRECT_QLEN])
 
 		q->direct_qlen = nla_get_u32(tb[TCA_HTB_DIRECT_QLEN]);