Browse Source

qlcnic: Fix memory leak.

o In case QLC_83XX_MBX_CMD_NO_WAIT command type the calling
  function does not free the memory as it does not wait for
  response. So free it when get a response from adapter after
  sending the command.

Signed-off-by: Rajesh Borundia <rajesh.borundia@qlogic.com>
Signed-off-by: Shahed Shaikh <shahed.shaikh@qlogic.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Rajesh Borundia 11 years ago
parent
commit
ab0648e8b6
1 changed files with 8 additions and 1 deletions
  1. 8 1
      drivers/net/ethernet/qlogic/qlcnic/qlcnic_sriov_common.c

+ 8 - 1
drivers/net/ethernet/qlogic/qlcnic/qlcnic_sriov_common.c

@@ -1370,7 +1370,7 @@ static int qlcnic_sriov_issue_cmd(struct qlcnic_adapter *adapter,
 
 
 	rsp = qlcnic_sriov_alloc_bc_trans(&trans);
 	rsp = qlcnic_sriov_alloc_bc_trans(&trans);
 	if (rsp)
 	if (rsp)
-		return rsp;
+		goto free_cmd;
 
 
 	rsp = qlcnic_sriov_prepare_bc_hdr(trans, cmd, seq, QLC_BC_COMMAND);
 	rsp = qlcnic_sriov_prepare_bc_hdr(trans, cmd, seq, QLC_BC_COMMAND);
 	if (rsp)
 	if (rsp)
@@ -1425,6 +1425,13 @@ err_out:
 
 
 cleanup_transaction:
 cleanup_transaction:
 	qlcnic_sriov_cleanup_transaction(trans);
 	qlcnic_sriov_cleanup_transaction(trans);
+
+free_cmd:
+	if (cmd->type == QLC_83XX_MBX_CMD_NO_WAIT) {
+		qlcnic_free_mbx_args(cmd);
+		kfree(cmd);
+	}
+
 	return rsp;
 	return rsp;
 }
 }