浏览代码

ath6kl: Remove unnecessary retrieval of first list entry in ath6kl_htc_tx_setup_scat_list()

It is unnecessary to take the first list entry from queue again for
transmission. Sometimes it may look racy when the head of the list
changes between subsequent retrival, but should not happen in
practical.

Reported-by: Jouni Malinen <jouni@qca.qualcomm.com>
Signed-off-by: Vasanthakumar Thiagarajan <vthiagar@qca.qualcomm.com>
Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
Vasanthakumar Thiagarajan 14 年之前
父节点
当前提交
aad9339fa2
共有 1 个文件被更改,包括 0 次插入1 次删除
  1. 0 1
      drivers/net/wireless/ath/ath6kl/htc.c

+ 0 - 1
drivers/net/wireless/ath/ath6kl/htc.c

@@ -389,7 +389,6 @@ static int ath6kl_htc_tx_setup_scat_list(struct htc_target *target,
 
 		rem_scat -= len;
 		/* now remove it from the queue */
-		packet = list_first_entry(queue, struct htc_packet, list);
 		list_del(&packet->list);
 
 		scat_req->scat_list[i].packet = packet;