瀏覽代碼

hwmon: (it87) Features mask must be 32 bit wide

Coverity reports:

result_independent_of_operands: data->features & (65536UL /* 1UL << 16 */)
is always 0 regardless of the values of its operands. This occurs as the
logical operand of if.

data->features needs to be 32 bit wide since there are more than 16 features.

Fixes: cc18da79d9b7 ("hwmon: (it87) Support up to 6 temperature sensors ... ");
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Guenter Roeck 9 年之前
父節點
當前提交
aa8b187eea
共有 1 個文件被更改,包括 1 次插入1 次删除
  1. 1 1
      drivers/hwmon/it87.c

+ 1 - 1
drivers/hwmon/it87.c

@@ -491,7 +491,7 @@ struct it87_sio_data {
 struct it87_data {
 	const struct attribute_group *groups[7];
 	enum chips type;
-	u16 features;
+	u32 features;
 	u8 peci_mask;
 	u8 old_peci_mask;