Răsfoiți Sursa

nl802154: Missing return in nl802154_add_llsec_key()

There was a missing return here so it meant that often
ieee802154_llsec_parse_key_id() was not called.

Fixes: a26c5fd7622d ('nl802154: add support for security layer')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Alexander Aring <alex.aring@gmail.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Dan Carpenter 10 ani în urmă
părinte
comite
aa6555622c
1 a modificat fișierele cu 1 adăugiri și 0 ștergeri
  1. 1 0
      net/ieee802154/nl802154.c

+ 1 - 0
net/ieee802154/nl802154.c

@@ -1534,6 +1534,7 @@ static int nl802154_add_llsec_key(struct sk_buff *skb, struct genl_info *info)
 
 
 	if (!attrs[NL802154_KEY_ATTR_USAGE_FRAMES] ||
 	if (!attrs[NL802154_KEY_ATTR_USAGE_FRAMES] ||
 	    !attrs[NL802154_KEY_ATTR_BYTES])
 	    !attrs[NL802154_KEY_ATTR_BYTES])
+		return -EINVAL;
 
 
 	if (ieee802154_llsec_parse_key_id(attrs[NL802154_KEY_ATTR_ID], &id) < 0)
 	if (ieee802154_llsec_parse_key_id(attrs[NL802154_KEY_ATTR_ID], &id) < 0)
 		return -ENOBUFS;
 		return -ENOBUFS;