Browse Source

iommu: smar: Fix return value check of create_irq()

ia64 returns a negative error code when allocation fails andx86
returns 0. Make it handle both.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Grant Likely <grant.likely@linaro.org>
Cc: Tony Luck <tony.luck@intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Fenghua Yu <fenghua.yu@intel.com>
Cc: x86@kernel.org
Acked-by: Joerg Roedel <joro@8bytes.org>
Cc: linux-ia64@vger.kernel.org
Cc: iommu@lists.linux-foundation.org
Link: http://lkml.kernel.org/r/20140507154336.178850165@linutronix.de
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Thomas Gleixner 11 years ago
parent
commit
aa5125a455
1 changed files with 1 additions and 1 deletions
  1. 1 1
      drivers/iommu/dmar.c

+ 1 - 1
drivers/iommu/dmar.c

@@ -1551,7 +1551,7 @@ int dmar_set_interrupt(struct intel_iommu *iommu)
 		return 0;
 		return 0;
 
 
 	irq = create_irq();
 	irq = create_irq();
-	if (!irq) {
+	if (irq <= 0) {
 		pr_err("IOMMU: no free vectors\n");
 		pr_err("IOMMU: no free vectors\n");
 		return -EINVAL;
 		return -EINVAL;
 	}
 	}