Эх сурвалжийг харах

NFC: st21nfca: Add error messages for unexpected HCI events

Potentially an unexpected HCI event may occur because of a
firmware bug. It could be transparent for the user but we should
at least log it.

Signed-off-by: Christophe Ricard <christophe-h.ricard@st.com>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
Christophe Ricard 9 жил өмнө
parent
commit
a9e062d059

+ 2 - 0
drivers/nfc/st21nfca/core.c

@@ -893,6 +893,8 @@ static int st21nfca_admin_event_received(struct nfc_hci_dev *hdev, u8 event,
 			}
 			}
 		}
 		}
 	break;
 	break;
+	default:
+		nfc_err(&hdev->ndev->dev, "Unexpected event on admin gate\n");
 	}
 	}
 	kfree_skb(skb);
 	kfree_skb(skb);
 	return 0;
 	return 0;

+ 1 - 0
drivers/nfc/st21nfca/dep.c

@@ -435,6 +435,7 @@ int st21nfca_dep_event_received(struct nfc_hci_dev *hdev,
 			return r;
 			return r;
 		return 0;
 		return 0;
 	default:
 	default:
+		nfc_err(&hdev->ndev->dev, "Unexpected event on card f gate\n");
 		return 1;
 		return 1;
 	}
 	}
 	kfree_skb(skb);
 	kfree_skb(skb);

+ 4 - 0
drivers/nfc/st21nfca/se.c

@@ -342,6 +342,7 @@ int st21nfca_connectivity_event_received(struct nfc_hci_dev *hdev, u8 host,
 		r = nfc_se_transaction(hdev->ndev, host, transaction);
 		r = nfc_se_transaction(hdev->ndev, host, transaction);
 		break;
 		break;
 	default:
 	default:
+		nfc_err(&hdev->ndev->dev, "Unexpected event on connectivity gate\n");
 		return 1;
 		return 1;
 	}
 	}
 	kfree_skb(skb);
 	kfree_skb(skb);
@@ -373,6 +374,9 @@ int st21nfca_apdu_reader_event_received(struct nfc_hci_dev *hdev,
 		mod_timer(&info->se_info.bwi_timer, jiffies +
 		mod_timer(&info->se_info.bwi_timer, jiffies +
 				msecs_to_jiffies(info->se_info.wt_timeout));
 				msecs_to_jiffies(info->se_info.wt_timeout));
 		break;
 		break;
+	default:
+		nfc_err(&hdev->ndev->dev, "Unexpected event on apdu reader gate\n");
+		return 1;
 	}
 	}
 
 
 exit:
 exit: