Home Explore Help
Sign In
GfA
/
linux_kernel
5
0
Fork 0
Files Issues 0 Pull Requests 0 Wiki
Browse Source

rtnl: RTM_GETNETCONF: fix wrong return value

An error response from a RTM_GETNETCONF request can return the positive
error value EINVAL in the struct nlmsgerr that can mislead userspace.

Signed-off-by: Anton Protopopov <a.s.protopopov@gmail.com>
Acked-by: Cong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Anton Protopopov 9 years ago
parent
cfdd28beb3
commit
a97eb33ff2
2 changed files with 2 additions and 2 deletions
Split View Show Diff Stats
  1. 1 1
      net/ipv4/devinet.c
  2. 1 1
      net/ipv6/addrconf.c

+ 1 - 1
net/ipv4/devinet.c
View File 

@@ -1847,7 +1847,7 @@ static int inet_netconf_get_devconf(struct sk_buff *in_skb,
 
 	if (err < 0)
 
 		goto errout;
 
 
-	err = EINVAL;
 
+	err = -EINVAL;
 
 	if (!tb[NETCONFA_IFINDEX])
 
 		goto errout;

+ 1 - 1
net/ipv6/addrconf.c
View File 

@@ -583,7 +583,7 @@ static int inet6_netconf_get_devconf(struct sk_buff *in_skb,
 
 	if (err < 0)
 
 		goto errout;
 
 
-	err = EINVAL;
 
+	err = -EINVAL;
 
 	if (!tb[NETCONFA_IFINDEX])
 
 		goto errout;