Browse Source

net: thunderx: remove a couple of redundant assignments

The assignment to pointer msg is redundant as it is never read, so
remove msg.  Also remove the first assignment to qset as this is not
read before the next re-assignment of a new value to qset in the
for-loop. Cleans up two clang warnings:

drivers/net/ethernet/cavium/thunder/nic_main.c:589:2: warning: Value
stored to 'msg' is never read
drivers/net/ethernet/cavium/thunder/nic_main.c:611:2: warning: Value
stored to 'qset' is never read

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Colin Ian King 7 years ago
parent
commit
a95157d72d
1 changed files with 0 additions and 4 deletions
  1. 0 4
      drivers/net/ethernet/cavium/thunder/nic_main.c

+ 0 - 4
drivers/net/ethernet/cavium/thunder/nic_main.c

@@ -584,9 +584,6 @@ static void nic_config_cpi(struct nicpf *nic, struct cpi_cfg_msg *cfg)
 static void nic_send_rss_size(struct nicpf *nic, int vf)
 static void nic_send_rss_size(struct nicpf *nic, int vf)
 {
 {
 	union nic_mbx mbx = {};
 	union nic_mbx mbx = {};
-	u64  *msg;
-
-	msg = (u64 *)&mbx;
 
 
 	mbx.rss_size.msg = NIC_MBOX_MSG_RSS_SIZE;
 	mbx.rss_size.msg = NIC_MBOX_MSG_RSS_SIZE;
 	mbx.rss_size.ind_tbl_size = nic->hw->rss_ind_tbl_size;
 	mbx.rss_size.ind_tbl_size = nic->hw->rss_ind_tbl_size;
@@ -608,7 +605,6 @@ static void nic_config_rss(struct nicpf *nic, struct rss_cfg_msg *cfg)
 	rssi_base = nic->rssi_base[cfg->vf_id] + cfg->tbl_offset;
 	rssi_base = nic->rssi_base[cfg->vf_id] + cfg->tbl_offset;
 
 
 	rssi = rssi_base;
 	rssi = rssi_base;
-	qset = cfg->vf_id;
 
 
 	for (; rssi < (rssi_base + cfg->tbl_len); rssi++) {
 	for (; rssi < (rssi_base + cfg->tbl_len); rssi++) {
 		u8 svf = cfg->ind_tbl[idx] >> 3;
 		u8 svf = cfg->ind_tbl[idx] >> 3;