Эх сурвалжийг харах

hwrng: exynos - Signedness bug in exynos_trng_do_read()

"val" needs to be signed for the error handling to work.

Fixes: 6cd225cc5d8a ("hwrng: exynos - add Samsung Exynos True RNG driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Acked-by: Łukasz Stelmach <l.stelmach@samsung.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Dan Carpenter 7 жил өмнө
parent
commit
a8bc71d496

+ 1 - 1
drivers/char/hw_random/exynos-trng.c

@@ -55,7 +55,7 @@ static int exynos_trng_do_read(struct hwrng *rng, void *data, size_t max,
 			       bool wait)
 			       bool wait)
 {
 {
 	struct exynos_trng_dev *trng;
 	struct exynos_trng_dev *trng;
-	u32 val;
+	int val;
 
 
 	max = min_t(size_t, max, (EXYNOS_TRNG_FIFO_LEN * 4));
 	max = min_t(size_t, max, (EXYNOS_TRNG_FIFO_LEN * 4));