Explorar el Código

net: off by one in inet6_pton()

If "scope_len" is sizeof(scope_id) then we would put the NUL terminator
one space beyond the end of the buffer.

Fixes: b1a951fe469e ("net/utils: generic inet_pton_with_scope helper")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Jens Axboe <axboe@fb.com>
Dan Carpenter hace 8 años
padre
commit
a88086e098
Se han modificado 1 ficheros con 1 adiciones y 1 borrados
  1. 1 1
      net/core/utils.c

+ 1 - 1
net/core/utils.c

@@ -339,7 +339,7 @@ static int inet6_pton(struct net *net, const char *src, u16 port_num,
 	    src + srclen != scope_delim && *scope_delim == '%') {
 	    src + srclen != scope_delim && *scope_delim == '%') {
 		struct net_device *dev;
 		struct net_device *dev;
 		char scope_id[16];
 		char scope_id[16];
-		size_t scope_len = min_t(size_t, sizeof(scope_id),
+		size_t scope_len = min_t(size_t, sizeof(scope_id) - 1,
 					 src + srclen - scope_delim - 1);
 					 src + srclen - scope_delim - 1);
 
 
 		memcpy(scope_id, scope_delim + 1, scope_len);
 		memcpy(scope_id, scope_delim + 1, scope_len);