Преглед на файлове

unicore: gpio: Be sure to clamp return value

As we want gpio_chip .get() calls to be able to return negative
error codes and propagate to drivers, we need to go over all
drivers and make sure their return values are clamped to [0,1].
We do this by using the ret = !!(val) design pattern.

Cc: Guan Xuetao <gxt@mprc.pku.edu.cn>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Linus Walleij преди 9 години
родител
ревизия
a80bb4c9ec
променени са 1 файла, в които са добавени 1 реда и са изтрити 1 реда
  1. 1 1
      arch/unicore32/kernel/gpio.c

+ 1 - 1
arch/unicore32/kernel/gpio.c

@@ -52,7 +52,7 @@ device_initcall(puv3_gpio_leds_init);
 
 
 static int puv3_gpio_get(struct gpio_chip *chip, unsigned offset)
 static int puv3_gpio_get(struct gpio_chip *chip, unsigned offset)
 {
 {
-	return readl(GPIO_GPLR) & GPIO_GPIO(offset);
+	return !!(readl(GPIO_GPLR) & GPIO_GPIO(offset));
 }
 }
 
 
 static void puv3_gpio_set(struct gpio_chip *chip, unsigned offset, int value)
 static void puv3_gpio_set(struct gpio_chip *chip, unsigned offset, int value)