Jelajahi Sumber

crypto: crypto4xx - remove bad list_del

alg entries are only added to the list, after the registration
was successful. If the registration failed, it was never added
to the list in the first place.

Signed-off-by: Christian Lamparter <chunkeey@googlemail.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Christian Lamparter 8 tahun lalu
induk
melakukan
a728a196d2
1 mengubah file dengan 2 tambahan dan 4 penghapusan
  1. 2 4
      drivers/crypto/amcc/crypto4xx_core.c

+ 2 - 4
drivers/crypto/amcc/crypto4xx_core.c

@@ -1033,12 +1033,10 @@ int crypto4xx_register_alg(struct crypto4xx_device *sec_dev,
 			break;
 		}
 
-		if (rc) {
-			list_del(&alg->entry);
+		if (rc)
 			kfree(alg);
-		} else {
+		else
 			list_add_tail(&alg->entry, &sec_dev->alg_list);
-		}
 	}
 
 	return 0;