Browse Source

iio: adc: ti-ads1015: don't return invalid value from buffer setup callbacks

pm_runtime_get_sync() and pm_runtime_put_autosuspend() return 0 on
success, 1 if the device's runtime PM status was already requested status
or error code on failure.  So a positive return value doesn't indicate an
error condition.

However, any non-zero return values from buffer preenable and postdisable
callbacks are recognized as an error and this driver reuses the return
value from pm_runtime_get_sync() and pm_runtime_put_autosuspend() in
these callbacks.  This change fixes the false error detections.

Cc: Daniel Baluta <daniel.baluta@gmail.com>
Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Cc: <Stable@vger.kernel.org>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Akinobu Mita 8 years ago
parent
commit
a6fe5e52d5
1 changed files with 1 additions and 1 deletions
  1. 1 1
      drivers/iio/adc/ti-ads1015.c

+ 1 - 1
drivers/iio/adc/ti-ads1015.c

@@ -235,7 +235,7 @@ static int ads1015_set_power_state(struct ads1015_data *data, bool on)
 		ret = pm_runtime_put_autosuspend(dev);
 		ret = pm_runtime_put_autosuspend(dev);
 	}
 	}
 
 
-	return ret;
+	return ret < 0 ? ret : 0;
 }
 }
 
 
 static
 static