瀏覽代碼

ASoC: Replace BUG() with WARN()

BUG() used in the driver is just to spit the stack trace on buggy
points, not really needed to stop the whole operation.  For that
purpose, it'd be more convenient to use WARN() instead with more
error information.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Mark Brown <broonie@linaro.org>
Takashi Iwai 11 年之前
父節點
當前提交
a6ed0608bd
共有 2 個文件被更改,包括 7 次插入5 次删除
  1. 4 2
      sound/soc/soc-cache.c
  2. 3 3
      sound/soc/soc-dapm.c

+ 4 - 2
sound/soc/soc-cache.c

@@ -39,7 +39,8 @@ static bool snd_soc_set_cache_val(void *base, unsigned int idx,
 		break;
 		break;
 	}
 	}
 	default:
 	default:
-		BUG();
+		WARN(1, "Invalid word_size %d\n", word_size);
+		break;
 	}
 	}
 	return false;
 	return false;
 }
 }
@@ -60,7 +61,8 @@ static unsigned int snd_soc_get_cache_val(const void *base, unsigned int idx,
 		return cache[idx];
 		return cache[idx];
 	}
 	}
 	default:
 	default:
-		BUG();
+		WARN(1, "Invalid word_size %d\n", word_size);
+		break;
 	}
 	}
 	/* unreachable */
 	/* unreachable */
 	return -1;
 	return -1;

+ 3 - 3
sound/soc/soc-dapm.c

@@ -1412,7 +1412,7 @@ static void dapm_seq_check_event(struct snd_soc_card *card,
 		power = 0;
 		power = 0;
 		break;
 		break;
 	default:
 	default:
-		BUG();
+		WARN(1, "Unknown event %d\n", event);
 		return;
 		return;
 	}
 	}
 
 
@@ -2001,7 +2001,7 @@ static ssize_t dapm_bias_read_file(struct file *file, char __user *user_buf,
 		level = "Off\n";
 		level = "Off\n";
 		break;
 		break;
 	default:
 	default:
-		BUG();
+		WARN(1, "Unknown bias_level %d\n", dapm->bias_level);
 		level = "Unknown\n";
 		level = "Unknown\n";
 		break;
 		break;
 	}
 	}
@@ -3416,7 +3416,7 @@ static int snd_soc_dai_link_event(struct snd_soc_dapm_widget *w,
 		break;
 		break;
 
 
 	default:
 	default:
-		BUG();
+		WARN(1, "Unknown event %d\n", event);
 		return -EINVAL;
 		return -EINVAL;
 	}
 	}