Browse Source

PM / hibernate: exclude freed pages from allocated pages printout

hibernate_preallocate_memory() prints out that how many pages are
allocated, but it doesn't take into consideration the pages freed by
free_unnecessary_pages(). Therefore, it always shows the count more
than actually allocated.

Signed-off-by: Wonhong Kwon <wonhong.kwon@lge.com>
[ rjw: Subject ]
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Wonhong Kwon 10 years ago
parent
commit
a64fc82c4f
1 changed files with 6 additions and 3 deletions
  1. 6 3
      kernel/power/snapshot.c

+ 6 - 3
kernel/power/snapshot.c

@@ -1472,9 +1472,9 @@ static inline unsigned long preallocate_highmem_fraction(unsigned long nr_pages,
 /**
 /**
  * free_unnecessary_pages - Release preallocated pages not needed for the image
  * free_unnecessary_pages - Release preallocated pages not needed for the image
  */
  */
-static void free_unnecessary_pages(void)
+static unsigned long free_unnecessary_pages(void)
 {
 {
-	unsigned long save, to_free_normal, to_free_highmem;
+	unsigned long save, to_free_normal, to_free_highmem, free;
 
 
 	save = count_data_pages();
 	save = count_data_pages();
 	if (alloc_normal >= save) {
 	if (alloc_normal >= save) {
@@ -1495,6 +1495,7 @@ static void free_unnecessary_pages(void)
 		else
 		else
 			to_free_normal = 0;
 			to_free_normal = 0;
 	}
 	}
+	free = to_free_normal + to_free_highmem;
 
 
 	memory_bm_position_reset(&copy_bm);
 	memory_bm_position_reset(&copy_bm);
 
 
@@ -1518,6 +1519,8 @@ static void free_unnecessary_pages(void)
 		swsusp_unset_page_free(page);
 		swsusp_unset_page_free(page);
 		__free_page(page);
 		__free_page(page);
 	}
 	}
+
+	return free;
 }
 }
 
 
 /**
 /**
@@ -1707,7 +1710,7 @@ int hibernate_preallocate_memory(void)
 	 * pages in memory, but we have allocated more.  Release the excessive
 	 * pages in memory, but we have allocated more.  Release the excessive
 	 * ones now.
 	 * ones now.
 	 */
 	 */
-	free_unnecessary_pages();
+	pages -= free_unnecessary_pages();
 
 
  out:
  out:
 	stop = ktime_get();
 	stop = ktime_get();