瀏覽代碼

mtd: cfi_cmdset_0020: Drop unnecessary static

Drop static on a local variable, when the variable is initialized before
any use on every possible execution path through the function.  The static
has no benefit, and dropping it reduces the code size.

The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@bad exists@
position p;
identifier x;
type T;
@@

static T x@p;
...
x = <+...x...+>

@@
identifier x;
expression e;
type T;
position p != bad.p;
@@

-static
 T x@p;
 ... when != x
     when strict
?x = e;
// </smpl>

The change in code size is indicates by the following output from the size
command.

before:
   text    data     bss     dec     hex filename
  16671      48      16   16735    415f drivers/mtd/chips/cfi_cmdset_0020.o

after:
   text    data     bss     dec     hex filename
  16639      48       8   16695    4137 drivers/mtd/chips/cfi_cmdset_0020.o

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Brian Norris <computersforpeace@gmail.com>
Julia Lawall 8 年之前
父節點
當前提交
a63be500c6
共有 1 個文件被更改,包括 1 次插入1 次删除
  1. 1 1
      drivers/mtd/chips/cfi_cmdset_0020.c

+ 1 - 1
drivers/mtd/chips/cfi_cmdset_0020.c

@@ -666,7 +666,7 @@ cfi_staa_writev(struct mtd_info *mtd, const struct kvec *vecs,
 	size_t	 totlen = 0, thislen;
 	size_t	 totlen = 0, thislen;
 	int	 ret = 0;
 	int	 ret = 0;
 	size_t	 buflen = 0;
 	size_t	 buflen = 0;
-	static char *buffer;
+	char *buffer;
 
 
 	if (!ECCBUF_SIZE) {
 	if (!ECCBUF_SIZE) {
 		/* We should fall back to a general writev implementation.
 		/* We should fall back to a general writev implementation.