Browse Source

Input: cyapa - fix variable being dereferenced before check

Fixes the warning regarding variable being dereferenced before check
'gen5_pip->resp_len'.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Dudley Du <dudl@cypress.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Dudley Du 10 years ago
parent
commit
a535a9f16c
1 changed files with 3 additions and 1 deletions
  1. 3 1
      drivers/input/mouse/cyapa_gen5.c

+ 3 - 1
drivers/input/mouse/cyapa_gen5.c

@@ -2557,7 +2557,9 @@ static bool cyapa_gen5_irq_cmd_handler(struct cyapa *cyapa)
 			 * trackpad device when booting/rebooting
 			 * trackpad device when booting/rebooting
 			 * their chrome book.
 			 * their chrome book.
 			 */
 			 */
-			length = *gen5_pip->resp_len;
+			length = 0;
+			if (gen5_pip->resp_len)
+				length = *gen5_pip->resp_len;
 			cyapa_empty_pip_output_data(cyapa,
 			cyapa_empty_pip_output_data(cyapa,
 					gen5_pip->resp_data,
 					gen5_pip->resp_data,
 					&length,
 					&length,