Prechádzať zdrojové kódy

netfilter: nft_reject: fix endianness in dump function

The dump function in nft_reject_ipv4 was not converting a u32
field to network order before sending it to userspace, this
needs to happen for consistency with other nf_tables and
nfnetlink subsystems.

Signed-off-by: Eric Leblond <eric@regit.org>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Eric Leblond 11 rokov pred
rodič
commit
a3adadf301
1 zmenil súbory, kde vykonal 1 pridanie a 1 odobranie
  1. 1 1
      net/ipv4/netfilter/nft_reject_ipv4.c

+ 1 - 1
net/ipv4/netfilter/nft_reject_ipv4.c

@@ -72,7 +72,7 @@ static int nft_reject_dump(struct sk_buff *skb, const struct nft_expr *expr)
 {
 	const struct nft_reject *priv = nft_expr_priv(expr);
 
-	if (nla_put_be32(skb, NFTA_REJECT_TYPE, priv->type))
+	if (nla_put_be32(skb, NFTA_REJECT_TYPE, htonl(priv->type)))
 		goto nla_put_failure;
 
 	switch (priv->type) {