Browse Source

ACPI: Enforce stricter checks for address space descriptors

Enforce stricter checks for address space descriptors according to
ACPI spec.

Signed-off-by: Jiang Liu <jiang.liu@linux.intel.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Jiang Liu 10 years ago
parent
commit
a274019fc3
1 changed files with 9 additions and 0 deletions
  1. 9 0
      drivers/acpi/resource.c

+ 9 - 0
drivers/acpi/resource.c

@@ -192,6 +192,15 @@ static bool acpi_decode_space(struct resource *res,
 	bool wp = addr->info.mem.write_protect;
 	bool wp = addr->info.mem.write_protect;
 	u64 len = attr->address_length;
 	u64 len = attr->address_length;
 
 
+	/*
+	 * Filter out invalid descriptor according to ACPI Spec 5.0, section
+	 * 6.4.3.5 Address Space Resource Descriptors.
+	 */
+	if ((addr->min_address_fixed != addr->max_address_fixed && len) ||
+	    (addr->min_address_fixed && addr->max_address_fixed && !len))
+		pr_debug("ACPI: Invalid address space min_addr_fix %d, max_addr_fix %d, len %llx\n",
+			 addr->min_address_fixed, addr->max_address_fixed, len);
+
 	res->start = attr->minimum;
 	res->start = attr->minimum;
 	res->end = attr->maximum;
 	res->end = attr->maximum;