Browse Source

of: overlay: pr_err from return NOTIFY_OK to overlay apply/remove

A device tree overlay notifier can return NOTIFY_OK, NOTIFY_STOP,
or an embedded errno.  overlay_notify() incorrectly reports an
error for NOTIFY_OK.

Reported-by: atull@kernel.org
Signed-off-by: Frank Rowand <frank.rowand@sony.com>
Signed-off-by: Rob Herring <robh@kernel.org>
Frank Rowand 7 years ago
parent
commit
a1d19bd4cf
1 changed files with 1 additions and 1 deletions
  1. 1 1
      drivers/of/overlay.c

+ 1 - 1
drivers/of/overlay.c

@@ -133,7 +133,7 @@ static int overlay_notify(struct overlay_changeset *ovcs,
 
 
 		ret = blocking_notifier_call_chain(&overlay_notify_chain,
 		ret = blocking_notifier_call_chain(&overlay_notify_chain,
 						   action, &nd);
 						   action, &nd);
-		if (ret == NOTIFY_STOP)
+		if (ret == NOTIFY_OK || ret == NOTIFY_STOP)
 			return 0;
 			return 0;
 		if (ret) {
 		if (ret) {
 			ret = notifier_to_errno(ret);
 			ret = notifier_to_errno(ret);