Selaa lähdekoodia

batman-adv: Remove unnecessary check for orig_ifinfo not NULL

orig_ifinfo is dereferenced multiple times in batadv_iv_ogm_update_seqnos
before the check for NULL is done. The function also exists at the
beginning when orig_ifinfo would have been NULL. This makes the check at
the end unnecessary and only confuses the reader/code analyzers.

Signed-off-by: Sven Eckelmann <sven@narfation.org>
Signed-off-by: Marek Lindner <mareklindner@neomailbox.ch>
Sven Eckelmann 10 vuotta sitten
vanhempi
commit
a0c77227ff
1 muutettua tiedostoa jossa 1 lisäystä ja 2 poistoa
  1. 1 2
      net/batman-adv/bat_iv_ogm.c

+ 1 - 2
net/batman-adv/bat_iv_ogm.c

@@ -1357,8 +1357,7 @@ batadv_iv_ogm_update_seqnos(const struct ethhdr *ethhdr,
 out:
 out:
 	spin_unlock_bh(&orig_node->bat_iv.ogm_cnt_lock);
 	spin_unlock_bh(&orig_node->bat_iv.ogm_cnt_lock);
 	batadv_orig_node_free_ref(orig_node);
 	batadv_orig_node_free_ref(orig_node);
-	if (orig_ifinfo)
-		batadv_orig_ifinfo_free_ref(orig_ifinfo);
+	batadv_orig_ifinfo_free_ref(orig_ifinfo);
 	return ret;
 	return ret;
 }
 }