Browse Source

clocksource: sun5i: Fix of_io_request_and_map error check

of_io_request_and map returns an error pointer, but the current code assumes
that on error the returned pointer will be NULL.

Obviously, that makes the check completely useless. Change the test to actually
check for the proper error code.

Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
Link: http://lkml.kernel.org/r/1430579006-32702-6-git-send-email-maxime.ripard@free-electrons.com
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Maxime Ripard 10 years ago
parent
commit
9fa8cc0a85
1 changed files with 1 additions and 1 deletions
  1. 1 1
      drivers/clocksource/timer-sun5i.c

+ 1 - 1
drivers/clocksource/timer-sun5i.c

@@ -324,7 +324,7 @@ static void __init sun5i_timer_init(struct device_node *node)
 	int irq;
 	int irq;
 
 
 	timer_base = of_io_request_and_map(node, 0, of_node_full_name(node));
 	timer_base = of_io_request_and_map(node, 0, of_node_full_name(node));
-	if (!timer_base)
+	if (IS_ERR(timer_base))
 		panic("Can't map registers");
 		panic("Can't map registers");
 
 
 	irq = irq_of_parse_and_map(node, 0);
 	irq = irq_of_parse_and_map(node, 0);