Browse Source

drm/exynos: fix drm driver de-initialization order

Since components have their own cleanup routines calling
drm_mode_config_cleanup before component_unbind_all causes errors
due to double free of KMS objects. The patch fixes it by changing
de-initialization order. Now it is exactly opposite to init order.

Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
Signed-off-by: Inki Dae <inki.dae@samsung.com>
Andrzej Hajda 11 years ago
parent
commit
9f3dd7dbc5
1 changed files with 4 additions and 4 deletions
  1. 4 4
      drivers/gpu/drm/exynos/exynos_drm_drv.c

+ 4 - 4
drivers/gpu/drm/exynos/exynos_drm_drv.c

@@ -136,14 +136,14 @@ static int exynos_drm_unload(struct drm_device *dev)
 	exynos_drm_device_subdrv_remove(dev);
 	exynos_drm_device_subdrv_remove(dev);
 
 
 	exynos_drm_fbdev_fini(dev);
 	exynos_drm_fbdev_fini(dev);
-	drm_vblank_cleanup(dev);
 	drm_kms_helper_poll_fini(dev);
 	drm_kms_helper_poll_fini(dev);
-	drm_mode_config_cleanup(dev);
 
 
+	component_unbind_all(dev->dev, dev);
+	drm_vblank_cleanup(dev);
+	drm_mode_config_cleanup(dev);
 	drm_release_iommu_mapping(dev);
 	drm_release_iommu_mapping(dev);
-	kfree(dev->dev_private);
 
 
-	component_unbind_all(dev->dev, dev);
+	kfree(dev->dev_private);
 	dev->dev_private = NULL;
 	dev->dev_private = NULL;
 
 
 	return 0;
 	return 0;