|
@@ -260,18 +260,9 @@ bfad_debugfs_write_regrd(struct file *file, const char __user *buf,
|
|
|
unsigned long flags;
|
|
|
void *kern_buf;
|
|
|
|
|
|
- kern_buf = kzalloc(nbytes, GFP_KERNEL);
|
|
|
-
|
|
|
- if (!kern_buf) {
|
|
|
- printk(KERN_INFO "bfad[%d]: Failed to allocate buffer\n",
|
|
|
- bfad->inst_no);
|
|
|
- return -ENOMEM;
|
|
|
- }
|
|
|
-
|
|
|
- if (copy_from_user(kern_buf, (void __user *)buf, nbytes)) {
|
|
|
- kfree(kern_buf);
|
|
|
- return -ENOMEM;
|
|
|
- }
|
|
|
+ kern_buf = memdup_user(buf, nbytes);
|
|
|
+ if (IS_ERR(kern_buf))
|
|
|
+ return PTR_ERR(kern_buf);
|
|
|
|
|
|
rc = sscanf(kern_buf, "%x:%x", &addr, &len);
|
|
|
if (rc < 2) {
|
|
@@ -336,18 +327,9 @@ bfad_debugfs_write_regwr(struct file *file, const char __user *buf,
|
|
|
unsigned long flags;
|
|
|
void *kern_buf;
|
|
|
|
|
|
- kern_buf = kzalloc(nbytes, GFP_KERNEL);
|
|
|
-
|
|
|
- if (!kern_buf) {
|
|
|
- printk(KERN_INFO "bfad[%d]: Failed to allocate buffer\n",
|
|
|
- bfad->inst_no);
|
|
|
- return -ENOMEM;
|
|
|
- }
|
|
|
-
|
|
|
- if (copy_from_user(kern_buf, (void __user *)buf, nbytes)) {
|
|
|
- kfree(kern_buf);
|
|
|
- return -ENOMEM;
|
|
|
- }
|
|
|
+ kern_buf = memdup_user(buf, nbytes);
|
|
|
+ if (IS_ERR(kern_buf))
|
|
|
+ return PTR_ERR(kern_buf);
|
|
|
|
|
|
rc = sscanf(kern_buf, "%x:%x", &addr, &val);
|
|
|
if (rc < 2) {
|