Browse Source

fsl/fman: double free on probe failure

"priv" is allocated with devm_kzalloc() so freeing it here with kfree()
will lead to a double free.

Fixes: 3933961682a3 ('fsl/fman: Add FMan MAC driver')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Dan Carpenter 9 years ago
parent
commit
9e02d8caaf
1 changed files with 0 additions and 1 deletions
  1. 0 1
      drivers/net/ethernet/freescale/fman/mac.c

+ 0 - 1
drivers/net/ethernet/freescale/fman/mac.c

@@ -961,7 +961,6 @@ _return_of_node_put:
 	of_node_put(dev_node);
 	of_node_put(dev_node);
 _return_dev_set_drvdata:
 _return_dev_set_drvdata:
 	kfree(priv->fixed_link);
 	kfree(priv->fixed_link);
-	kfree(priv);
 	dev_set_drvdata(dev, NULL);
 	dev_set_drvdata(dev, NULL);
 _return:
 _return:
 	return err;
 	return err;