Просмотр исходного кода

[PATCH] v9fs: fix fid check in v9fs_create

Fix an incorrect check whether a fid was allocated in v9fs_create and if it
should be freed on error.

Signed-off-by: Latchesar Ionkov <lucho@ionkov.net>
Cc: Eric Van Hensbergen <ericvh@ericvh.myip.org>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Latchesar Ionkov 19 лет назад
Родитель
Сommit
9d7fa40098
1 измененных файлов с 1 добавлено и 1 удалено
  1. 1 1
      fs/9p/vfs_inode.c

+ 1 - 1
fs/9p/vfs_inode.c

@@ -300,7 +300,7 @@ v9fs_create(struct v9fs_session_info *v9ses, u32 pfid, char *name, u32 perm,
 	fid = V9FS_NOFID;
 	fid = V9FS_NOFID;
 
 
 put_fid:
 put_fid:
-	if (fid >= 0)
+	if (fid != V9FS_NOFID)
 		v9fs_put_idpool(fid, &v9ses->fidpool);
 		v9fs_put_idpool(fid, &v9ses->fidpool);
 
 
 	kfree(fcall);
 	kfree(fcall);