浏览代码

[SCSI] megaraid: cleanup type issue in mega_build_cmd()

On 64 bit systems the current code sets 32 bits of "seg" and leaves the
other 32 uninitialized.  It doesn't matter since the variable is never
used.  But it's still messy and we should fix it.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Adam Radford <aradford@gmail.com>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
Dan Carpenter 13 年之前
父节点
当前提交
9d5d93e32a
共有 1 个文件被更改,包括 2 次插入2 次删除
  1. 2 2
      drivers/scsi/megaraid.c

+ 2 - 2
drivers/scsi/megaraid.c

@@ -524,7 +524,7 @@ mega_build_cmd(adapter_t *adapter, Scsi_Cmnd *cmd, int *busy)
 	mega_passthru	*pthru;
 	mega_passthru	*pthru;
 	scb_t	*scb;
 	scb_t	*scb;
 	mbox_t	*mbox;
 	mbox_t	*mbox;
-	long	seg;
+	u32	seg;
 	char	islogical;
 	char	islogical;
 	int	max_ldrv_num;
 	int	max_ldrv_num;
 	int	channel = 0;
 	int	channel = 0;
@@ -858,7 +858,7 @@ mega_build_cmd(adapter_t *adapter, Scsi_Cmnd *cmd, int *busy)
 
 
 			/* Calculate Scatter-Gather info */
 			/* Calculate Scatter-Gather info */
 			mbox->m_out.numsgelements = mega_build_sglist(adapter, scb,
 			mbox->m_out.numsgelements = mega_build_sglist(adapter, scb,
-					(u32 *)&mbox->m_out.xferaddr, (u32 *)&seg);
+					(u32 *)&mbox->m_out.xferaddr, &seg);
 
 
 			return scb;
 			return scb;