Browse Source

rpmsg: glink: smem: Ensure ordering during tx

Ensure the ordering of the fifo write and the update of the write index,
so that the index is not updated before the data has landed in the fifo.

Acked-By: Chris Lew <clew@codeaurora.org>
Reported-by: Arun Kumar Neelakantam <aneela@codeaurora.org>
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Bjorn Andersson 7 years ago
parent
commit
9d32497361
1 changed files with 3 additions and 0 deletions
  1. 3 0
      drivers/rpmsg/qcom_glink_smem.c

+ 3 - 0
drivers/rpmsg/qcom_glink_smem.c

@@ -183,6 +183,9 @@ static void glink_smem_tx_write(struct qcom_glink_pipe *glink_pipe,
 	if (head >= pipe->native.length)
 	if (head >= pipe->native.length)
 		head -= pipe->native.length;
 		head -= pipe->native.length;
 
 
+	/* Ensure ordering of fifo and head update */
+	wmb();
+
 	*pipe->head = cpu_to_le32(head);
 	*pipe->head = cpu_to_le32(head);
 }
 }