瀏覽代碼

[media] DaVinci-VPBE: Return an error code only as a constant in vpbe_probe()

* Return an error code without storing it in an intermediate variable.

* Delete the local variable "ret" which became unnecessary with
  this refactoring.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Markus Elfring 9 年之前
父節點
當前提交
9d2fe9ae29
共有 1 個文件被更改,包括 1 次插入2 次删除
  1. 1 2
      drivers/media/platform/davinci/vpbe.c

+ 1 - 2
drivers/media/platform/davinci/vpbe.c

@@ -818,7 +818,6 @@ static int vpbe_probe(struct platform_device *pdev)
 {
 	struct vpbe_device *vpbe_dev;
 	struct vpbe_config *cfg;
-	int ret = -EINVAL;
 
 	if (!pdev->dev.platform_data) {
 		v4l2_err(pdev->dev.driver, "No platform data\n");
@@ -830,7 +829,7 @@ static int vpbe_probe(struct platform_device *pdev)
 	    !cfg->osd.module_name[0] ||
 	    !cfg->venc.module_name[0]) {
 		v4l2_err(pdev->dev.driver, "vpbe display module names not defined\n");
-		return ret;
+		return -EINVAL;
 	}
 
 	vpbe_dev = kzalloc(sizeof(*vpbe_dev), GFP_KERNEL);