Browse Source

fbdev: geocode: remove unneeded NULL check

the check for info is not required as we are checking it immediately
after gxfb_init_fbinfo() and lxfb_init_fbinfo() and returnig -ENOMEM
if it is NULL.

Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Sudip Mukherjee 10 years ago
parent
commit
9cb13ba435
2 changed files with 4 additions and 8 deletions
  1. 2 4
      drivers/video/fbdev/geode/gxfb_core.c
  2. 2 4
      drivers/video/fbdev/geode/lxfb_core.c

+ 2 - 4
drivers/video/fbdev/geode/gxfb_core.c

@@ -444,10 +444,8 @@ static int gxfb_probe(struct pci_dev *pdev, const struct pci_device_id *id)
 		pci_release_region(pdev, 1);
 	}
 
-	if (info) {
-		fb_dealloc_cmap(&info->cmap);
-		framebuffer_release(info);
-	}
+	fb_dealloc_cmap(&info->cmap);
+	framebuffer_release(info);
 	return ret;
 }
 

+ 2 - 4
drivers/video/fbdev/geode/lxfb_core.c

@@ -577,10 +577,8 @@ err:
 		pci_release_region(pdev, 3);
 	}
 
-	if (info) {
-		fb_dealloc_cmap(&info->cmap);
-		framebuffer_release(info);
-	}
+	fb_dealloc_cmap(&info->cmap);
+	framebuffer_release(info);
 
 	return ret;
 }