瀏覽代碼

mm/memory.c: actually remap enough memory

For whatever reason, generic_access_phys() only remaps one page, but
actually allows to access arbitrary size.  It's quite easy to trigger
large reads, like printing out large structure with gdb, which leads to a
crash.  Fix it by remapping correct size.

Fixes: 28b2ee20c7cb ("access_process_vm device memory infrastructure")
Signed-off-by: Grazvydas Ignotas <notasas@gmail.com>
Cc: Rik van Riel <riel@redhat.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Grazvydas Ignotas 10 年之前
父節點
當前提交
9cb12d7b4c
共有 1 個文件被更改,包括 1 次插入1 次删除
  1. 1 1
      mm/memory.c

+ 1 - 1
mm/memory.c

@@ -3462,7 +3462,7 @@ int generic_access_phys(struct vm_area_struct *vma, unsigned long addr,
 	if (follow_phys(vma, addr, write, &prot, &phys_addr))
 	if (follow_phys(vma, addr, write, &prot, &phys_addr))
 		return -EINVAL;
 		return -EINVAL;
 
 
-	maddr = ioremap_prot(phys_addr, PAGE_SIZE, prot);
+	maddr = ioremap_prot(phys_addr, PAGE_ALIGN(len + offset), prot);
 	if (write)
 	if (write)
 		memcpy_toio(maddr + offset, buf, len);
 		memcpy_toio(maddr + offset, buf, len);
 	else
 	else