瀏覽代碼

crypto: cavium - Fix couple of static checker errors

Fix the following smatch errors
cptvf_reqmanager.c:333 do_post_process() warn: variable dereferenced
before check 'cptvf'
cptvf_main.c:825 cptvf_remove() error: we previously assumed 'cptvf'
could be null

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: George Cherian <george.cherian@cavium.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
George Cherian 8 年之前
父節點
當前提交
9bd829041b
共有 2 個文件被更改,包括 5 次插入3 次删除
  1. 3 1
      drivers/crypto/cavium/cpt/cptvf_main.c
  2. 2 2
      drivers/crypto/cavium/cpt/cptvf_reqmanager.c

+ 3 - 1
drivers/crypto/cavium/cpt/cptvf_main.c

@@ -815,8 +815,10 @@ static void cptvf_remove(struct pci_dev *pdev)
 {
 {
 	struct cpt_vf *cptvf = pci_get_drvdata(pdev);
 	struct cpt_vf *cptvf = pci_get_drvdata(pdev);
 
 
-	if (!cptvf)
+	if (!cptvf) {
 		dev_err(&pdev->dev, "Invalid CPT-VF device\n");
 		dev_err(&pdev->dev, "Invalid CPT-VF device\n");
+		return;
+	}
 
 
 	/* Convey DOWN to PF */
 	/* Convey DOWN to PF */
 	if (cptvf_send_vf_down(cptvf)) {
 	if (cptvf_send_vf_down(cptvf)) {

+ 2 - 2
drivers/crypto/cavium/cpt/cptvf_reqmanager.c

@@ -330,8 +330,8 @@ void do_post_process(struct cpt_vf *cptvf, struct cpt_info_buffer *info)
 {
 {
 	struct pci_dev *pdev = cptvf->pdev;
 	struct pci_dev *pdev = cptvf->pdev;
 
 
-	if (!info || !cptvf) {
-		dev_err(&pdev->dev, "Input params are incorrect for post processing\n");
+	if (!info) {
+		dev_err(&pdev->dev, "incorrect cpt_info_buffer for post processing\n");
 		return;
 		return;
 	}
 	}